Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimum supported xcode version #3482

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

thisisabhash
Copy link
Member

Issue #

None

Description

Update minimum supported xcode version for installation on supported platforms

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner January 24, 2024 21:21
phantumcode
phantumcode previously approved these changes Jan 24, 2024
Copy link
Contributor

@sebaland sebaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some rewording suggestion

@thisisabhash thisisabhash merged commit a512b2e into main Jan 25, 2024
78 checks passed
@thisisabhash thisisabhash deleted the chore/update-min-xcode-version-readme branch January 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants